Skip to content

[DO NOT MERGE] Added unit test for pod role loading #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mayabar
Copy link
Collaborator

@mayabar mayabar commented Apr 30, 2025

Ref #98

@mayabar mayabar requested review from shmuelk and irar2 April 30, 2025 12:18
@irar2
Copy link

irar2 commented May 5, 2025

LGTM

@elevran
Copy link
Collaborator

elevran commented May 6, 2025

@mayabar please do not merge here but move the scheduler

@elevran elevran changed the title Added unit test for pod role loading [DO NOT MERGE] Added unit test for pod role loading May 6, 2025
@clubanderson clubanderson force-pushed the dev branch 2 times, most recently from 9ef49b8 to 5ee8225 Compare May 7, 2025 14:44
@elevran
Copy link
Collaborator

elevran commented May 8, 2025

@mayabar I think this one can be closed (in favor of a new test?) as we no longer have Role attribute.

@shaneutt
Copy link
Collaborator

We're archiving this fork soon so I think we should be good to close this, but if we need to re-open this for some reason feel free 🫡

@shaneutt shaneutt closed this May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants